Skip to content

NRL 1288/1304 Reporting allow multiple log groups #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jackleary merged 8 commits into from
Feb 17, 2025
Merged

NRL 1288/1304 Reporting allow multiple log groups #840

jackleary merged 8 commits into from
Feb 17, 2025

Conversation

@jackleary
Copy link
Contributor

@jackleary jackleary commented Feb 17, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Feb 17, 2025

🚀 PR environment successfully deployed.
Commit Hash: cc64d6dfc012b0e0a863f6e3759a1d1bbc2fd23f
URL: https://nrl1288-385aa4.api.record-locator.dev.national.nhs.uk/

@jackleary jackleary changed the title NRL 1288 Reporting allow multiple log groups NRL 1288/1304 Reporting allow multiple log groups Feb 17, 2025
@github-actions
Copy link

github-actions bot commented Feb 17, 2025

🚀 PR environment successfully deployed.
Commit Hash: 341187078db414e1d5da8af6b5230551c4aac238
URL: https://nrl1288-385aa4.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

github-actions bot commented Feb 17, 2025

🚀 PR environment successfully deployed.
Commit Hash: 53839cc9e80c4c8931c581405f5e829facd7865f
URL: https://nrl1288-385aa4.api.record-locator.dev.national.nhs.uk/

mattdean3-nhs
mattdean3-nhs reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@mattdean3-nhs mattdean3-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks fine to me, nice work 💪

There's 2 sonarcloud issues reported by the quality gate - they either need resolving or ignore - if ignoring, you can do that from the sonarcloud UI

@github-actions
Copy link

github-actions bot commented Feb 17, 2025

🚀 PR environment successfully deployed.
Commit Hash: 7c669947d79eb97a659ba8bbf1f289aef47c81d0
URL: https://nrl1288-385aa4.api.record-locator.dev.national.nhs.uk/

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 17, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link

github-actions bot commented Feb 17, 2025

🚀 PR environment successfully deployed.
Commit Hash: 589a5ae3bba648d22faed90356a7c5f661773b4b
URL: https://nrl1288-385aa4.api.record-locator.dev.national.nhs.uk/

@jackleary jackleary merged commit 5b2d8b2 into develop Feb 17, 2025
8 checks passed
@jackleary jackleary deleted the feature/jale13-nrl-1288-reporting-allow-multiple-log-groups branch February 17, 2025 14:50
@github-actions
Copy link

github-actions bot commented Feb 17, 2025

💥 Something went wrong while destroying the pull request environment.
Check Output Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattdean3-nhs mattdean3-nhs mattdean3-nhs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jackleary @mattdean3-nhs